# HG changeset patch # User Peter Sanchez # Date 1282257561 25200 # Thu Aug 19 15:39:21 2010 -0700 # Node ID 4bd10335d97231f0ccbfc369952e527e1d583d6d # Parent 27343e28be1d5cb87a2c56c3259c39228e2a9825 Added RENEW command diff --git a/cartfreakapi/views.py b/cartfreakapi/views.py --- a/cartfreakapi/views.py +++ b/cartfreakapi/views.py @@ -5,6 +5,8 @@ from cartfreakapi import CartFreakError +REQUIRED_VARS = ('command', 'hash') +VALID_COMMANDS = ('CREATE', 'REMOVE', 'RENEW', 'COMPLETE') ERROR_STR = 'ERROR %s' @@ -13,12 +15,9 @@ raise ImproperlyConfigured( u'No CartFreak API setting configured for %s' % key_name ) - - required = ('command', 'hash') - valid_commands = ('CREATE', 'REMOVE', 'COMPLETE') cf_key = getattr(settings, key_name) - for req in required: + for req in REQUIRED_VARS: if req not in request.POST: err_msg = 'No %s varaible was sent' % req return HttpResponse(ERROR_STR % err_msg) @@ -27,7 +26,7 @@ command = request.POST.get('command') _hash = hashlib.sha1(cf_key + command).hexdigest() - if command not in valid_commands: + if command not in VALID_COMMANDS: return HttpResponse(ERROR_STR % 'Invalid command sent') if _hash != in_hash: